Skip to content

Conversation

@apetenchea
Copy link
Member

Fixing the users parameter docstring for the Database.create_database function.
The official documentation states that only the root user will be added by default, if no users are specified.
The docstring is incorect because it claims that also the "current user" is included.

@apetenchea apetenchea requested a review from aMahanna October 5, 2024 16:39
@apetenchea apetenchea self-assigned this Oct 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (0f46b50) to head (e7b5a6b).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (0f46b50) and HEAD (e7b5a6b). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (0f46b50) HEAD (e7b5a6b)
32 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #350       +/-   ##
===========================================
- Coverage   95.94%   83.70%   -12.25%     
===========================================
  Files          26       26               
  Lines        4296     4296               
===========================================
- Hits         4122     3596      -526     
- Misses        174      700      +526     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apetenchea apetenchea merged commit 630c41a into main Oct 6, 2024
37 checks passed
@apetenchea apetenchea deleted the fix/database-docstring branch October 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants